kdereview exemption for PolicyKit-KDE

Thiago Macieira thiago at kde.org
Mon Nov 17 08:02:30 GMT 2008

Aaron J. Seigo wrote:
>* It is two exectubles, one is 844 LOC and the other is 648 LOC. They
>communicate with PolicyKit via D-Bus, and link against libkdeui (and
> it's dependencies) and the PolicyKit libraries (e.g. the dbus
> convenience lib)

I don't see how you can write a proper event loop integration in 650 lines 
of code. Much less the integration plus the application code.

So, where is the event loop integration code for the convenience lib? Or, 
another related question: why use the lib instead of QtDBus generated 
wrappers around the D-Bus calls?

  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081117/0fcb1e21/attachment.sig>

More information about the kde-core-devel mailing list