KDE/kdelibs/kdeui/dialogs

[Thiago Macieira]

Adriaan de Groot wrote:
>On Sunday 20 July 2008 14:29, Thiago Macieira wrote:
>> However, code shouldn't depend on indirect #includes.
>
>Sadly, lots of our code does just that. I remember doing a cleanup round
> once on kdelibs where I removed all the non-needed includes for each
> installed .h file, and promptly broke every other SVN module. I think
> searching for "ade fucks up" in the archives of our -devel lists will
> show this :)
>
>Cleaning up includes is a tedious and annoying process (also in the face
> of #ifdefs). In general we should fix assumptions about indirect
> includes in the places where those assumptions are made, and I'd posit
> that assumptions about indirect includes are bugs not covered by any
> source-compatibility requirements.

Agreed. Fixing a missing include is something that anyone can do when 
rebuilding. It's a lot more difficult when you have to understand the 
code... :-)

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080720/a17b4045/attachment.sig>