Fwd: KDirOperator patchlets

[Daniel Molkentin]

Heya,

somehow Carstens mail didn't make it through. Thus sending it on his behalf.

Cheers,
  Daniel

----------  Weitergeleitete Nachricht  ----------

Subject: Fwd: KDirOperator patchlets
Date: Sonntag, 20. Juli 2008
From: Carsten Pfeiffer <pfeiffer at kde.org>
To: danimo at kde.org

Hiya,

since I got a few friendly complaints that KuickShow doesn't work with KDE4, 
it seems I need to revive it a little.

Firtst thing I noticed (after getting it to compile at all) was that 
KDirOperator doesn't send out the fileHighlighted() signal e.g. when changing 
the current item. It only does that in multi-selection mode or when no 
selection is set at all. See attached kdiroperator-fileHighlighted.patch.

The second thing is that pressing return on the current item does not emit 
fileSelected() but fileHighlighted(). I'm wondering if this was an accident 
or done on purpose. See attached kdiroperator-fileSelected.patch.

I already committed the former patch to HEAD. Ideally, I'd like to see both in 
4.1.

Thanks for any comments,
Carsten

-- 
Carsten Pfeiffer

-------------------------------------------------------

-- 
Be part of something amazing, visit
http://www.kde.org/announcements/4.0/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdiroperator-fileHighlighted.patch
Type: text/x-diff
Size: 513 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080720/a769b336/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdiroperator-fileSelected.patch
Type: text/x-diff
Size: 385 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080720/a769b336/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080720/a769b336/attachment.sig>