[patch] KStandardDirs: one crash fix + code cleanups

Jaroslaw Staniek js at iidea.pl
Tue Jul 8 20:52:49 BST 2008

(for review)

Important fix:
- Windows: avoid crash in KStandardDirs::exists(fullPath) for empty fullPath

Minor cleanups:
- KStandardDirs::addResourceDir(): check for empty absdir or type
- use more constness
- lookupPrefix(): do not check for relpath.isEmpty() twice
- replace checking for (bool)filter.length() with !filter.isEmpty()
- use QString::isEmpty() instead of isNull()
- use default value of 2nd arg for QString::mid()

regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kstandarddirs_trunk.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080708/f9fd0ec7/attachment.ksh>

More information about the kde-core-devel mailing list