[patch] KStandardDirs: one crash fix + code cleanups

[Allen Winter]

On Tuesday 08 July 2008 15:52:49 Jaroslaw Staniek wrote:
> 
> (for review)
> 
> Important fix:
> - Windows: avoid crash in KStandardDirs::exists(fullPath) for empty fullPath
> 
> Minor cleanups:
> - KStandardDirs::addResourceDir(): check for empty absdir or type
> - use more constness
> - lookupPrefix(): do not check for relpath.isEmpty() twice
> - replace checking for (bool)filter.length() with !filter.isEmpty()
> - use QString::isEmpty() instead of isNull()
> - use default value of 2nd arg for QString::mid()
> 
Certainly the crash fix is good.
The other changes also look ok to me.
Did you run the kstandarddirstest unit test?