[patch] KdePrint::createPrintDialog() on non-X11

Jaroslaw Staniek js-oCjyBhvHQAU at public.gmane.org
Tue Jul 8 00:39:05 BST 2008


For review.

Based on the fact that only X11 supports custom setting tabs in the print 
dialog (http://doc.trolltech.com/4.4/qabstractprintdialog.html#setOptionTabs)

On non-X11 tagets:
- do not build kcupsoptions*.{cpp|ui} and do not instantiate KCupsOptions*
   objects
- reparent widgets from QList<QWidget*> customTabs to the dialog even if we
   don't use them, to avoid leaks

Also:
- simplify the code by calling one overload of createPrintDialog() from another
- add more docs for non-X11 systems and about object ownership

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cups_only_on_x11.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080708/73db129e/attachment.ksh>
-------------- next part --------------
_______________________________________________
Kde-windows mailing list
Kde-windows-RoXCvvDuEio at public.gmane.org
https://mail.kde.org/mailman/listinfo/kde-windows


More information about the kde-core-devel mailing list