[PATCH] Phonon Gstreamer backend
thiago at kde.org
Fri Jan 18 17:55:37 GMT 2008
Andre Magalhaes wrote:
>So here it goes:
> - Fix the build and remove compile warnings
> - Standardize #ifndef directives on header files
> - Make it work again
>Ok to commit?
Comments from me:
#1 looks ok. I'll let Jens comment on it though.
#2 looks mostly ok. I don't know if there was a reason for Phonon_UI
instead of simply Phonon, so I'll again let Jens comment on it.
#3 is definitely a no-go. Don't link to kdecore and don't #include KDE
headers in the code. This code must compile with Qt 4.3+Phonon and Qt 4.4
alone (without KDE).
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel