[PATCH] Phonon Gstreamer backend

[Andre Magalhaes]

On Jan 18, 2008 2:55 PM, Thiago Macieira <thiago at kde.org> wrote:
> Comments from me:
>
> #1 looks ok. I'll let Jens comment on it though.
>
> #2 looks mostly ok. I don't know if there was a reason for Phonon_UI
> instead of simply Phonon, so I'll again let Jens comment on it.
Great.

> #3 is definitely a no-go. Don't link to kdecore and don't #include KDE
> headers in the code. This code must compile with Qt 4.3+Phonon and Qt 4.4
> alone (without KDE).
So what should I do here? If I use Q_EXPORT_PLUGIN2 I get the error
"The library phonon_gstreamer does not offer a KDE 4 compatible
factory.". I just did that cause the xine plugin was doing the same.
But i saw in the ds9 plugin that it does:

#ifdef PHONON_MAKE_QT_ONLY_BACKEND
Q_EXPORT_PLUGIN2(phonon_ds9, Phonon::DS9::Backend);
#else
#include <kpluginfactory.h>
K_PLUGIN_FACTORY(DS9BackendFactory, registerPlugin<Phonon::DS9::Backend>();)
K_EXPORT_PLUGIN(DS9BackendFactory("ds9backend"))
#endif

Should I do the same? What needs to be done to make it work?

BR

-- 
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko at gmail.com
MSN:   andremoreira at msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com