[PATCH] kio_sftp error detection

[Albert Astals Cid]

A Dissabte 27 Desembre 2008, Michael Leupold va escriure:
> Hi there,
>
> for quite a while kio_sftp has been a little poor detecting errors. The
> result of it was (is) usually an empty KDialog with some "unknown error"
> caption. Those errors get especially annoying when they happen during
> KUrlCompletion.
>
> I just figured that the sftp kioslave didn't know about some errors. So I
> implemented:
> - "Name or service not known" (eg. server name is not resolvable)
> - "Connection refused" (eg. no ssh server running on the port specified)
> - "Bad port" (displayed by OpenSSH if the port number is outside the
> allowed TCP port range)
>
> Additionally I removed the modal dialog boxes because I think a kioslave
> shouldn't show dialogboxes for those known errors (as I understand it
> SlaveBase::error() is meant for that, right?). I didn't introduce any new
> strings so far but used the ssh command's output (which might look strange
> sometimes). 

I object to that, strange and untranslatable messages is not something we want 
to show to our users.

If you think this fix is needed before KDE 4.3 i suggest asking kde-i18n-doc 
mailing list for an excemption and add proper understandable and translatable 
messages.

Also you modified the plink regexp line, seems a bad idea if you can't test 
it ;-)

Albert

> I also tried to keep interoperability with plink and non-free 
> ssh (not sure if I succeeded - I can't test).
>
> Pretty please someone review and tell me if I may commit.
>
> Thanks and kind regards,
> Michael