[PATCH] kio_sftp error detection
lemma at confuego.org
Sat Dec 27 23:23:59 GMT 2008
On Sunday 28 December 2008 00:12:08 Albert Astals Cid wrote:
> A Dissabte 27 Desembre 2008, Michael Leupold va escriure:
> > Additionally I removed the modal dialog boxes because I think a kioslave
> > shouldn't show dialogboxes for those known errors (as I understand it
> > SlaveBase::error() is meant for that, right?). I didn't introduce any new
> > strings so far but used the ssh command's output (which might look
> > strange sometimes).
> I object to that, strange and untranslatable messages is not something we
> want to show to our users.
> If you think this fix is needed before KDE 4.3 i suggest asking
> kde-i18n-doc mailing list for an excemption and add proper understandable
> and translatable messages.
I agree. I was thinking about doing that but hesitated because we're that far
along the release schedule already. I'm happy you proposed it though.
> > I also tried to keep interoperability with plink and non-free
> > ssh (not sure if I succeeded - I can't test).
> > Pretty please someone review and tell me if I may commit.
> Also you modified the plink regexp line, seems a bad idea if you can't test
> it ;-)
I do have plink around and I'm sure the "plink: Release" line is wrong as the
"Release" part is probably configurable. Debian putty gives me:
plink: Unidentified build, Nov 16 2008 22:37:21
I actually meant "I can't test right now". I'll be able to at least test putty
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel