[PATCH] kio_sftp error detection

Michael Leupold lemma at confuego.org
Sat Dec 27 22:55:32 GMT 2008

Hi there,

for quite a while kio_sftp has been a little poor detecting errors. The result 
of it was (is) usually an empty KDialog with some "unknown error" caption. 
Those errors get especially annoying when they happen during KUrlCompletion.

I just figured that the sftp kioslave didn't know about some errors. So I 
- "Name or service not known" (eg. server name is not resolvable)
- "Connection refused" (eg. no ssh server running on the port specified)
- "Bad port" (displayed by OpenSSH if the port number is outside the allowed 
TCP port range)

Additionally I removed the modal dialog boxes because I think a kioslave 
shouldn't show dialogboxes for those known errors (as I understand it 
SlaveBase::error() is meant for that, right?). I didn't introduce any new 
strings so far but used the ssh command's output (which might look strange 
sometimes). I also tried to keep interoperability with plink and non-free ssh 
(not sure if I succeeded - I can't test).

Pretty please someone review and tell me if I may commit.

Thanks and kind regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kio-sftp-no-nag-error-detection.diff
Type: text/x-patch
Size: 5485 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081227/e8b516f5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081227/e8b516f5/attachment.sig>

More information about the kde-core-devel mailing list