Review needed: Add support of lzma in KDE

[Thiago Macieira]

Per Øyvind Karlsen wrote:
>For '#define __STDC_LIMIT_MACROS 1',  this is needed by
> LZMA_VLI_VALUE_UNKNOWN which is defined the following way in
> lzma/vli.h: '#define
>LZMA_VLI_VALUE_UNKNOWN UINT64_MAX'.
>I guess the best way to avoid dependency on C99 macro and to stay easily
>understandable is to change '#define __STDC_LIMIT_MACROS 1' to '#define
>UINT64_MAX (uint64_t)-1'.

That's not a solution either. There may be a header defining UINT64_MAX. 
If you define it, there will be a compilation error.

No. Report as an error to the lzma developers if their header doesn't work 
when included all by itself.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080824/fc285eda/attachment.sig>