Review needed: Add support of lzma in KDE

Per Øyvind Karlsen peroyvind at
Sun Aug 24 23:49:20 BST 2008

Søndag 24 august 2008 18:54:07 skrev Thiago Macieira:
> Per Øyvind Karlsen wrote:
> >For '#define __STDC_LIMIT_MACROS 1',  this is needed by
> > LZMA_VLI_VALUE_UNKNOWN which is defined the following way in
> > lzma/vli.h: '#define
> >I guess the best way to avoid dependency on C99 macro and to stay easily
> >understandable is to change '#define __STDC_LIMIT_MACROS 1' to '#define
> >UINT64_MAX (uint64_t)-1'.
> That's not a solution either. There may be a header defining UINT64_MAX.
> If you define it, there will be a compilation error.
I guess using #ifndef wouldn't be acceptable.
> No. Report as an error to the lzma developers if their header doesn't work
> when included all by itself.
Yes, probably makes sense to solve it there in stead.
Any suggestions for any standard macros equivalent to ie. __WORDSIZE that 
could be used to avoid arch specific headers?
Per Øyvind Karlsen

More information about the kde-core-devel mailing list