Adding a section "Touching old code" to the Kdelibs Coding Style (was: Re: [PATCH] Set program icon name by KAboutData)

[David Jarvie]

On Monday 21 April 2008 15:10, Maksim Orlovich wrote:
>> --- 8< ----
>> == Touching old code ==
>>
>> You improve old code to follow the style guide as you touch it. If you
>> change
>> a method significantly, you redo the whole method; if you just touch a
>> few lines, then you improve just the local context.
>>
>> Code in kdelibs was historically created in a mix of personal coding
>> styles.
>> As the commit annotation function of subversion (<tt>svn blame</tt>)
>> operates
>> on a per-line base a complete adaption to the official coding style
>> would have turned this function unusable for too large parts.
>> --- 8< ----
>
> This suggestion can lead to inconsistency of code that's already
> consistently indented, just in a different style. Please don't.

+1

-- 
David Jarvie.
KAlarm author & maintainer.
http://www.astrojar.org.uk/kalarm