Adding a section "Touching old code" to the Kdelibs Coding Style (was: Re: [PATCH] Set program icon name by KAboutData)

Maksim Orlovich mo85 at cornell.edu
Mon Apr 21 15:10:36 BST 2008


> --- 8< ----
> == Touching old code ==
>
> You improve old code to follow the style guide as you touch it. If you
> change
> a method significantly, you redo the whole method; if you just touch a few
> lines, then you improve just the local context.
>
> Code in kdelibs was historically created in a mix of personal coding
> styles.
> As the commit annotation function of subversion (<tt>svn blame</tt>)
> operates
> on a per-line base a complete adaption to the official coding style would
> have turned this function unusable for too large parts.
> --- 8< ----

This suggestion can lead to inconsistency of code that's already
consistently indented, just in a different style. Please don't.






More information about the kde-core-devel mailing list