[patch] KIconLoader fallback fix (and slight refactoring)

Aaron J. Seigo aseigo at kde.org
Tue Apr 8 08:50:08 BST 2008


On Monday 07 April 2008, Jakob Petsovits wrote:
> Hence, I need your review. This patch makes icon interoperability with
> naming spec compliant icons actually work, take a bit of time to see if the
> code is ok.

it looks right; it adds inherited themes, then default themes and 
addThemeByName ensures there aren't duplicates added. you may want to put a 
comment in the code that the order of calling (inherited and *then* defaults) 
is important (and why) just so the code remains a bit more maintainable for 
future spelunkers. =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080408/262ea813/attachment.sig>


More information about the kde-core-devel mailing list