[PATCH] Fix overridden virtual method in KTimeZone classes

Michael Pyne michael.pyne at kdemail.net
Fri Nov 30 21:26:53 GMT 2007

On Friday 30 November 2007, David Jarvie wrote:
> Thanks to the -Woverloaded-virtual option, I've discovered that the virtual
> method KTimeZoneSource::parse() isn't reimplemented in ICalTimeZoneSource,
> and because it isn't applicable to ICalTimeZoneSource, the way
> KTimeZone::parse() and KTimeZone::data() operate could easily produce loss
> of data or a crash. The attached BIC patch will allow ICalTimeZone (and any
> other derived classes with similar characteristics) to be fixed. I don't
> see any way to fix it without changing the API.

Is this really BIC?

I could be missing something but I see no header changes that would make it 

 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071130/9b6e14d5/attachment.sig>

More information about the kde-core-devel mailing list