[PATCH] Fix overridden virtual method in KTimeZone classes

David Jarvie djarvie at kde.org
Fri Nov 30 22:09:44 GMT 2007

On Friday 30 November 2007 21:26:53 Michael Pyne wrote:
> On Friday 30 November 2007, David Jarvie wrote:
> > Thanks to the -Woverloaded-virtual option, I've discovered that the
> > virtual method KTimeZoneSource::parse() isn't reimplemented in
> > ICalTimeZoneSource, and because it isn't applicable to
> > ICalTimeZoneSource, the way
> > KTimeZone::parse() and KTimeZone::data() operate could easily produce
> > loss of data or a crash. The attached BIC patch will allow ICalTimeZone
> > (and any other derived classes with similar characteristics) to be fixed.
> > I don't see any way to fix it without changing the API.
> Is this really BIC?
> I could be missing something but I see no header changes that would make it
> BIC.

I agree - I realised after sending the mail that it isn't BIC.

David Jarvie.
KAlarm author and maintainer.

More information about the kde-core-devel mailing list