[PATCH] Fix overridden virtual method in KTimeZone classes
David Jarvie
djarvie at kde.org
Fri Nov 30 18:21:56 GMT 2007
Thanks to the -Woverloaded-virtual option, I've discovered that the virtual
method KTimeZoneSource::parse() isn't reimplemented in ICalTimeZoneSource,
and because it isn't applicable to ICalTimeZoneSource, the way
KTimeZone::parse() and KTimeZone::data() operate could easily produce loss of
data or a crash. The attached BIC patch will allow ICalTimeZone (and any
other derived classes with similar characteristics) to be fixed. I don't see
any way to fix it without changing the API.
Can I commit?
--
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/kalarm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tz.diff
Type: text/x-diff
Size: 3930 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071130/77345a86/attachment.diff>
More information about the kde-core-devel
mailing list