[PATCH] KStaticDeleter -> K_GLOBAL_STATIC in kconfig_compiler
kretz at kde.org
Mon May 21 13:59:54 BST 2007
On Monday 21 May 2007, Thiago Macieira wrote:
> Matthias Kretz said:
> > Please review the attached patch. I'd like to commit today.
> Looks good. Two comments, though (non-blocking):
> 1) the object creation is not thread-safe. Would that be a problem? I
> don't know if you can use that kind of object from many threads.
Yes, I realized that. But since all the rest of the generated code didn't look
threadsafe to me I didn't care too much.
Any idea how to make it threadsafe while still allowing subclassing (I know
how to do it using a mutex...)?
> 2) any chance you can name the static variable something unique instead of
> "s_self"? If you have to kconfig_compiled classes in the same project,
> "s_self" would prevent enable-final from working.
I'll make it "s_global<className>"
Matthias Kretz (Germany) <><
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the kde-core-devel