[PATCH] KStaticDeleter -> K_GLOBAL_STATIC in kconfig_compiler
thiago at kde.org
Mon May 21 10:23:12 BST 2007
Matthias Kretz said:
> Please review the attached patch. I'd like to commit today.
Looks good. Two comments, though (non-blocking):
1) the object creation is not thread-safe. Would that be a problem? I
don't know if you can use that kind of object from many threads.
2) any chance you can name the static variable something unique instead of
"s_self"? If you have to kconfig_compiled classes in the same project,
"s_self" would prevent enable-final from working.
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
More information about the kde-core-devel