kkeyserver_x11.cpp contains #ifdefs for *all* platforms

[Andreas Hartmetz]

Am Freitag, 16. März 2007 14:26:54 schrieb Marijn Kruisselbrink:
> Hi
>
> When I wrote the mac-specific stuff for kglobalaccel/kkeyserver I
> already did this in a separate file, but it seems I forgot to remove
> some #ifdefs when refactoring some of the existing code to get the
> platform-independent stuff in kkeyserver.cpp/.h. Since I didn't have
> linux or windows available at the time of that refactoring, I didn't
> want to touch the parts specific for those platforms, but at least it
> should be safe to remove all the mac code from the x11 file.
>
OK, mac ifdefs will be removed. One down, one to go.
If I get no protests in the next four hours, I'll commit. According 
to "...should be safe to remove...", this would be removal of dead code only.

> Marijn
>
> Andreas Hartmetz wrote:
> > Hi!
> >
> > During some cleanup/revision work in the shortcuts area of kdelibs, I
> > found that kdeui/util/kkeyserver_x11.cpp contains #ifdef Q_WS_X11, #ifdef
> > Q_WS_WIN and Q_WS_MAC.
> > kkeyserver.h only includes kkeyserver_x11.h if Q_WS_X11 is defined, so
> > this is clearly bogus, and the other files including it,
> > kglobalaccel_x11.h, also only include it on X11.
> > I'd like to ask KDE-Mac and KDE-Windows maintainers to create
> > architecture-specific files and put everything that is needed on these
> > platforms in there. Note that "everything that is needed" might
> > mean "nothing" so that the #ifdefs could be just deleted.
> > Enlightening comments on the history and planned future of this part of
> > kdelibs are also welcome. It's in bad shape right now.
> >
> > Regards,
> > Andreas