kkeyserver_x11.cpp contains #ifdefs for *all* platforms

David Faure faure at kde.org
Fri Mar 16 13:59:08 GMT 2007


On Friday 16 March 2007, Andreas Hartmetz wrote:
> Am Freitag, 16. März 2007 14:26:54 schrieb Marijn Kruisselbrink:
> > Hi
> >
> > When I wrote the mac-specific stuff for kglobalaccel/kkeyserver I
> > already did this in a separate file, but it seems I forgot to remove
> > some #ifdefs when refactoring some of the existing code to get the
> > platform-independent stuff in kkeyserver.cpp/.h. Since I didn't have
> > linux or windows available at the time of that refactoring, I didn't
> > want to touch the parts specific for those platforms, but at least it
> > should be safe to remove all the mac code from the x11 file.
> >
> OK, mac ifdefs will be removed. One down, one to go.
> If I get no protests in the next four hours, I'll commit. According 
> to "...should be safe to remove...", this would be removal of dead code only.

Yes initially that file was included by all platforms, which was a bit messy indeed.
As the CMakeLists.txt file says, it's now only included if Q_WS_X11 so you can remove
all Q_WS_ ifdefs.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list