New class KListWidgetSearchLine

[Benjamin Meyer]

On Tuesday 13 March 2007 7:18 pm, David Faure wrote:
> On Monday 12 March 2007, Albert Astals Cid wrote:
> > A Dilluns 12 Març 2007, Benjamin Meyer va escriure:
> > > On Sunday 11 March 2007 23:10, Albert Astals Cid wrote:
> > > > Well, it's not a new class, it's just porting K3ListViewSearchLine to
> > > > KListWidget so i can use it on KIconDialog that i ported from
> > > > QIconView to KListWidget.
> > > >
> > > > I'm attaching the two files. I want to commit tomorrow as it's just a
> > > > port from the old class and seems to be working quite good.
> > > >
> > > > Albert
> > >
> > > Hmm, well before it goes in we need two apps that use it,
> >
> > Does "lots of apps" count?
>
> I agree with Albert, there is ample need for this.
>
> Benjamin, kdelibs isn't bad competition for Qt, there's no need to shoot
> down any suggestion for a widget in kdeui ;)

I didn't shoot it down.  I was simply giving feedback based upon the KDE 
policie for kdelibs.  To go into libs KDE require two apps and docs.  The 
class is small, docs should not be a problem to write same goes to porting 
two apps to use it.  I though autotests were required, but looking at the 
policy autotests were never added.  Provided the policy is followed I see no 
reason why it can't go in.

> > > and autotests.
> >
> > You need autotests this?

It would be nice.

> Autotests never hurt, but it would be quite unfair to require it for gui
> stuff at this point, we don't have many examples of gui unittests yet. I do
> request unittests for core stuff, since those are easier to write, but for
> gui stuff we need more experience in that area [btw being able to read TT's
> unit tests would help...]

There is some talk in TT to try to get some of the autotests released, but 
nothing is currently happening that I know of.  Like you mentioned a big 
reason is that it is an excellent example of usage of the qtestlib.

-Benjamin Meyer

-- 
aka icefox
Public Key: http://www.icefox.net/public_key.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070313/4658bf1b/attachment.sig>