[patch] fix building of phonon tests under mingw

[Holger Schröder]

On Wednesday 06 June 2007 00:12:05 Matthias Kretz wrote:
> On Tuesday 05 June 2007, Holger Schröder wrote:
> > Hi,
> >
> > the following patch makes the phonon tests build under mingw under
> > windows xp.
> >
> > it needs to link against kdewin32, so that it can find ::sleep.
>
> Oh, I still have sleeps in the test code? I'll replace that. I guess then
> linking to kdewin32 is not needed, is it?
>
yes, whe i comment out the both ::sleep calls in bytestreamtest.cpp and 
bytestreamtest2.cpp, it compiles also without kdewin32.

> > and when methodtest.cpp is build, PHONON_EXPORT must be defined empty. i
> > came up with the patch to phonon_export.h.cmake, because a define like
> > this like in solid obviuosly does not work:
> >
> > if(WIN32)
> >  set_target_properties(methodtest PROPERTIES COMPILE_FLAGS
> > -DPHONON_EXPORT=) endif(WIN32)
> >
> > ok to commit ?
>
> The patch to phonon_export.h.cmake looks good, but for completeness I'd add
> the #ifdef for non-WIN32 and PHONON_NO_EXPORT too. Then you can also define
> PHONON_EXPORT to "" unconditionally for methodtest.

commited

regards, Holger