[PATCH] KPluginSelector new method

Rafael Fernández López ereslibre at gmail.com
Sun Jun 3 11:36:22 BST 2007


On Sunday 03 June 2007 12:14:58 you wrote:
> > Also the 'AutomaticallyAdded' enum value doesn't tell us why its
> > auto-added, having a 'DependencyAutoAdded' might be more clear.
>
> Same here :)

Ok, here we should keep AutomaticallyAdded. This has nothing to do with 
dependencies. We say plugins were "ManuallyAdded" if they were added to the 
KPluginSelector through the method:

     void addPlugins(const QList<KPluginInfo*> &pluginInfoList,
                     PluginLoadMethod pluginLoadMethod = ReadConfigFile,
                     const QString &categoryName = QString(),
                     const QString &categoryKey = QString(),
                     const KSharedConfig::Ptr &config = KSharedConfig::Ptr());

On other case (using componentName or whatever) they will be automatically 
added. This is because when you add manually them, KPluginSelector doesn't 
need to read any services or anything, just retrieve the information from 
QList<KPluginSelector*>. Addittionally, as happens with Kate, you probably 
don't want KPluginSelector to load the dialog and put them "checked or 
uncheccked" depending on the KGlobal::config() file, but on 
KateDocumentConfig in Kate's case for example, where plugins can be 
enabled-or-disabled by document, not by KGlobal::config(). For this reason I 
added this method, because this way of adding plugins lets the library 
user "more freedom" to work with plugins if he/she wants so.


Bye,
Rafael Fernández López.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070603/4507bae0/attachment.sig>


More information about the kde-core-devel mailing list