[PATCH] KPluginSelector new method

Rafael Fernández López ereslibre at gmail.com
Sun Jun 3 11:14:58 BST 2007


2007/6/3, Thomas Zander <zander at kde.org>:
> On Sunday 03 June 2007 03:39:22 Rafael Fernández López wrote:
> A minor nag;  I personally think that 'WayAdded' can be misread. I suggest
> the enum name 'AddMethod'
> the wayAdded() method could stay the way it is.

No problem with me. I'm not a native speaker, so I assume you're right here :)

> Also the 'AutomaticallyAdded' enum value doesn't tell us why its
> auto-added, having a 'DependencyAutoAdded' might be more clear.

Same here :)

I'm not attaching patches again since these changes won't affect
public header, but implementation details. The patch itself is the
same, but changing what Thomas said.

Thanks for the suggestions.

Bye,
Rafael Fernández López.


More information about the kde-core-devel mailing list