[PATCH] KPluginSelector new method

[Thomas Zander]

On Sunday 03 June 2007 03:39:22 Rafael Fernández López wrote:
> +    enum WayAdded
> +    {
> +        AutomaticallyAdded = 0,
> +        ManuallyAdded
> +    };

A minor nag;  I personally think that 'WayAdded' can be misread. I suggest 
the enum name 'AddMethod'
the wayAdded() method could stay the way it is.

Also the 'AutomaticallyAdded' enum value doesn't tell us why its 
auto-added, having a 'DependencyAutoAdded' might be more clear.

-- 
Thomas Zander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070603/d93f8413/attachment.sig>