So late... again

[Aaron J. Seigo]

On Monday 15 January 2007 19:24, Rafael Fernández López wrote:
> 3) I won't be able to handle the designer created form resizing. You

that's because you don't have a layout in the top level of your form. see the 
attched revised ui file.

moreover, you shouldn't have buttons in your layout "Cancel" and "Accept". 
besides being in the wrong order and having the wrong labels, 
UIConfigurationDialog should subclass KDialog rather than QWidget and call 
setButtons(Cancel|Ok);

> can see on uiserver_p.h the new configuration window inherits from
> QWidget and Ui::configurationDialog, but if this widget is resized,
> the designer created one wont be resized. BTW, if I do:
>
> 867:    setupUi(this);
>
> and then setLayout(verticalLayout);

how can this even work? setLayout takes a QLayout* and verticalLayout is a 
QWidget*? moreover, verticalLayout is already a child of the widget at this 
point, so if you tried to call setLayout with it you'd have problems anyways.

once you've made the appropriate changes, can you please make a screenshot of 
the final dialog and send it to kde-usability-devel at kde.org for review[1]? 
thanks...

[1]  all new UI in kdelibs, and in a good world kdebase, should automatically 
go through this step

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
<ui version="4.0" >
 <class>configurationDialog</class>
 <widget class="QWidget" name="configurationDialog" >
  <property name="geometry" >
   <rect>
    <x>0</x>
    <y>0</y>
    <width>351</width>
    <height>247</height>
   </rect>
  </property>
  <property name="windowTitle" >
   <string>Progress Manager - Configuration</string>
  </property>
  <layout class="QVBoxLayout" >
   <property name="margin" >
    <number>9</number>
   </property>
   <property name="spacing" >
    <number>6</number>
   </property>
   <item>
    <widget class="QGroupBox" name="groupAppearance" >
     <property name="title" >
      <string>Appearance</string>
     </property>
     <layout class="QVBoxLayout" >
      <property name="margin" >
       <number>9</number>
      </property>
      <property name="spacing" >
       <number>6</number>
      </property>
      <item>
       <widget class="QRadioButton" name="radioList" >
        <property name="text" >
         <string>Show all jobs in a list</string>
        </property>
       </widget>
      </item>
      <item>
       <widget class="QRadioButton" name="radioTree" >
        <property name="text" >
         <string>Show all jobs in a tree</string>
        </property>
       </widget>
      </item>
     </layout>
    </widget>
   </item>
   <item>
    <widget class="QGroupBox" name="groupFinishedJobs" >
     <property name="title" >
      <string>Finished jobs</string>
     </property>
     <layout class="QVBoxLayout" >
      <property name="margin" >
       <number>9</number>
      </property>
      <property name="spacing" >
       <number>6</number>
      </property>
      <item>
       <widget class="QRadioButton" name="radioMove" >
        <property name="text" >
         <string>Move them to a different list</string>
        </property>
       </widget>
      </item>
      <item>
       <widget class="QRadioButton" name="radioRemove" >
        <property name="text" >
         <string>Remove them</string>
        </property>
       </widget>
      </item>
     </layout>
    </widget>
   </item>
   <item>
    <spacer>
     <property name="orientation" >
      <enum>Qt::Vertical</enum>
     </property>
     <property name="sizeHint" >
      <size>
       <width>20</width>
       <height>40</height>
      </size>
     </property>
    </spacer>
   </item>
   <item>
    <layout class="QHBoxLayout" >
     <property name="margin" >
      <number>0</number>
     </property>
     <property name="spacing" >
      <number>6</number>
     </property>
     <item>
      <widget class="QPushButton" name="buttonCancel" >
       <property name="text" >
        <string>Cancel</string>
       </property>
      </widget>
     </item>
     <item>
      <widget class="QPushButton" name="buttonAccept" >
       <property name="text" >
        <string>Accept</string>
       </property>
      </widget>
     </item>
    </layout>
   </item>
  </layout>
 </widget>
 <resources/>
 <connections/>
</ui>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070116/fec2da46/attachment.sig>