3.5.6 'make check' problems... LOTS of them

[David Faure]

On Friday 02 February 2007, Matthew Woehlke wrote:
> > Please use ktempdir instead of a hardcoded /tmp location and atexit.
> 
> Please don't check 'file:/tmp' then? :-)
I'm checking /tmp, I'm not creating /tmp. Creating is the problem (symlink attack).

> > In trunk I have removed the trash test long ago (moved to kdebase where kio_trash is),
> > but I'm missing the "not root" test [why would anyone compile as root? that's not recommended...],
> > I'll add it.
> 
> Because I am lazy. :-) And because I wanted a system-wide installation, 
The usual way is 'sudo make install'.

> I did check that it works for a non-root user, although my non-root user 
> still needs the 0-perm folder because said user can read /root.
Well the test could use a ::access() call to ensure that the dir isn't readable, I guess.

> So did you just say you're gong to clean this up, or that I should? You 
> seem to indicate both.

I fixed trunk, I'm letting 3.5 tests to you.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).