[PATCH] KProcess port of khelpcenter

Ralf Habacker ralf.habacker at freenet.de
Sat Dec 15 22:38:48 GMT 2007

Oswald Buddenhagen schrieb:
> On Fri, Dec 14, 2007 at 08:52:46PM +0100, Ralf Habacker wrote:
>> thanks for this pointer. I think asynchronously handling isn't required: I 
>> would add the following code to indicate in the log that there is an error.
>>    if (!m_meinproc->waitForStarted(1000)) {
>>        kDebug() << "could not start process" << m_meinproc->program();
>>       delete m_meinproc;
>>    }
> that's a bit slim - the user is left in the dark about the cause.
Displaying messages in the status bar does not help, they will be 
overwritten immediatly by other messages. Any better idea ?
> not sure whether further cleanup (nulling the pointer, etc.) is
> required - i don't know that code, obviously.
I will see  :-)
>> BTW: Do you have any suggestion about the required timeout on non win32 
>> platforms ?
> it's in the milliseconds range as well. but i would not override the 30
> sec default - under adverse conditions (high cpu load and massive
> swapping) one second can be easily exceeded. and after all, there isn't
> much point in reducing the timeout.
okay, then we use the default value


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: khelpcenter-kprocess-2.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071215/1a1c5a79/attachment.ksh>

More information about the kde-core-devel mailing list