[PATCH] KProcess port of khelpcenter

Oswald Buddenhagen ossi at kde.org
Fri Dec 14 21:08:19 GMT 2007

On Fri, Dec 14, 2007 at 08:52:46PM +0100, Ralf Habacker wrote:
> thanks for this pointer. I think asynchronously handling isn't required: I 
> would add the following code to indicate in the log that there is an error.
>    if (!m_meinproc->waitForStarted(1000)) {
>        kDebug() << "could not start process" << m_meinproc->program();
>       delete m_meinproc;
>    }
that's a bit slim - the user is left in the dark about the cause.
not sure whether further cleanup (nulling the pointer, etc.) is
required - i don't know that code, obviously.

> BTW: Do you have any suggestion about the required timeout on non win32 
> platforms ?
it's in the milliseconds range as well. but i would not override the 30
sec default - under adverse conditions (high cpu load and massive
swapping) one second can be easily exceeded. and after all, there isn't
much point in reducing the timeout.

Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
Confusion, chaos, panic - my work here is done.

More information about the kde-core-devel mailing list