[PATCH] KHistoryComboBox --- make konq's location box not fail half the time

Sebastian Kuegler sebas at kde.org
Fri Dec 14 22:19:22 GMT 2007


On Friday 14 December 2007 19:32:59 Maksim Orlovich wrote:
> Hi...  We currently have a critical bug in trunk where konqueror's combo
> does not work half the time (#153568). The reason is that we rely on the
> activated() signal from QComboBox as the enter trigger. However, this
> signal does not get emitted all the time --- there is a workaround to
> simulate it when the combo is in NoInsert mode already --- but
> QComboBox::Private::_q_returnPressed() might also not emit it if the box
> is full. The attached extends the emulation. I would appreciate review of
> that, particularly since I am a bit concerned by the whole
> emulation-of-signal thing...

I can't comment on the code, but your patch fixes the problem here. I didn't 
get it after ~30 minutes of websurfing.

> Thanks,
> Maks
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071214/32a72f18/attachment.sig>


More information about the kde-core-devel mailing list