[PATCH] KHistoryComboBox --- make konq's location box not fail half the time

Maksim Orlovich mo85 at cornell.edu
Fri Dec 14 18:32:59 GMT 2007


Hi...  We currently have a critical bug in trunk where konqueror's combo
does not work half the time (#153568). The reason is that we rely on the
activated() signal from QComboBox as the enter trigger. However, this
signal does not get emitted all the time --- there is a workaround to
simulate it when the combo is in NoInsert mode already --- but
QComboBox::Private::_q_returnPressed() might also not emit it if the box
is full. The attached extends the emulation. I would appreciate review of
that, particularly since I am a bit concerned by the whole
emulation-of-signal thing...

Thanks,
Maks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_combo.diff
Type: text/x-diff
Size: 888 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071214/5004395e/attachment.diff>


More information about the kde-core-devel mailing list