[PATCH] KHistoryComboBox --- make konq's location box not fail half the time

Allen Winter winter at kde.org
Sun Dec 16 16:49:31 GMT 2007

On Friday 14 December 2007 17:19:22 Sebastian Kuegler wrote:
> On Friday 14 December 2007 19:32:59 Maksim Orlovich wrote:
> > Hi...  We currently have a critical bug in trunk where konqueror's combo
> > does not work half the time (#153568). The reason is that we rely on the
> > activated() signal from QComboBox as the enter trigger. However, this
> > signal does not get emitted all the time --- there is a workaround to
> > simulate it when the combo is in NoInsert mode already --- but
> > QComboBox::Private::_q_returnPressed() might also not emit it if the box
> > is full. The attached extends the emulation. I would appreciate review of
> > that, particularly since I am a bit concerned by the whole
> > emulation-of-signal thing...
> I can't comment on the code, but your patch fixes the problem here. I didn't 
> get it after ~30 minutes of websurfing.

Yep, it works well here too.

More information about the kde-core-devel mailing list