[PATCH] kdeui/dialogs/kmessagebox.cpp

[Simon Hausmann]

On Saturday 25 August 2007 21:27:29 Rafael Fernández López wrote:
> Hi,
>
> I would like if this is OK to commit. I wonder if this is internally done
> by Qt if it is compiled with RIGHT_TO_LEFT symbol.
>
> I also wonder how this works on distributions. They always ship Qt compiled
> with LEFT_TO_RIGHT so we have to check always layoutDirection() ?
>
> For keeping quality on KDE, if the case is that Qt is always shipped
> compiled with left to right support and we need to check layoutDirection(),
> I really think we should consider take a look on how things are for RTL
> languages. This "fix" is because KMessageBox is called from
> KPluginSelector, and I noticed that when it was shown the layout direction
> wasn't respected (I forced it on KPluginSelector to RTL for testing
> purposes).

Widgets inherit the layout direction automatically from their parent unless 
they are windows, in which case the application's layout direction is used. 
Normally there is only one layout direction, which is the application's one. 
Only in rare cases I think it makes sense to specifically override it, which 
is why you _can_ set it per widget.

But for testing purposes I recommend starting your application with "-reverse" 
or by setting the layout direction manually on the application object.


Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070826/3137b18d/attachment.sig>