[PATCH] KIO assert in KDE4 branch

[David Faure]

On Monday 27 March 2006 21:19, Richard Lärkäng wrote:
> Hi!
> 
> I ran into an assert when trying to run code that was using KIO::FileCopyJob. 
> The assert that was hit was
> assert(m_putJob); in FileCopyJob::slotData()
> 
> And after a lot of debugging (I wasn't very familiar with the KIO code before) 
> I think I have found the cause of it. The problem seems to be that
> Connection::resume() and suspend() doesn't do what they should do, so the 
> put-job won't be suspended and will be finished before it has written 
> anything.
> 
> During the kde4 porting, the Connection class was changed from using 
> QSocketNotifier to just using signals from a KStreamSocket in some cases but 
> there weren't any changes in resume() and suspend(). So the attached patch 
> connects and disconnects the signals there too.

Excellent! Thanks for that fix.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).