[PATCH] KIO assert in KDE4 branch

Richard Lärkäng nouseforaname at home.se
Mon Mar 27 20:19:52 BST 2006


Hi!

I ran into an assert when trying to run code that was using KIO::FileCopyJob. 
The assert that was hit was
assert(m_putJob); in FileCopyJob::slotData()

And after a lot of debugging (I wasn't very familiar with the KIO code before) 
I think I have found the cause of it. The problem seems to be that
Connection::resume() and suspend() doesn't do what they should do, so the 
put-job won't be suspended and will be finished before it has written 
anything.

During the kde4 porting, the Connection class was changed from using 
QSocketNotifier to just using signals from a KStreamSocket in some cases but 
there weren't any changes in resume() and suspend(). So the attached patch 
connects and disconnects the signals there too.

So, does the attached patch look OK? 

/Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kio.patch
Type: text/x-diff
Size: 905 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060327/4ec19f0f/attachment.patch>


More information about the kde-core-devel mailing list