New Feature (sort of): new DCOP method for KNotes

[Michael Brade]

On Saturday 10 June 2006 20:47, Thiago Macieira wrote:
> Michael Brade wrote:
> >Instead of saying "this is not how it works" you could have taken 60
> > seconds more and actually have a look at the small patch instead.
>
> I did. And I don't feel qualified to approve it. 
?!
ok, I have attached a new patch without the no-ops. Maybe that helps?

> Who's the KNotes maintainer?
me.

> Who's the maintainer of the module KNotes is in? 
I guess that would be Cornelius? (kdepim)

> >Regarding trunk: no, this patch cannot be in trunk, for trunk has no
> > DCOP anymore. And other people have added new DCOP methods to KDE 3.5.4
> > already without asking.
>
> How about the rest of the rules? Has it been tested widely?
Come on, a method that returns the current color of a note doesn't have to be 
tested widely, does it? (define "widely"...) To me this is such a simple case 
that I'd say, either it works once, and then it works always, or it doesn't 
work at all. 

And the setColor() DCOP call: it uses a method that the config dialog is 
already using to set the color, so that one is already "widely tested".

Cheers,
-- 
Rohan (Michael) Brade;         KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
  °--web: http://www.kde.org/people/michaelb.html

KDE 4: Beyond Your Expectations
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PATCH.dcop-color
Type: text/x-diff
Size: 4238 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060610/7d2fb49a/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060610/7d2fb49a/attachment.sig>