Some changes on kio/kio/jobuidelegate

David Faure faure at kde.org
Thu Dec 28 21:12:25 GMT 2006


On Thursday 28 December 2006 21:16, Rafael Fernández López wrote:
> org::kde::KIO::UIServer uiserver("org.kde.kio_uiserver", "/UIServer",
> QDBusConnection::sessionBus());
> 
> could be better...

Yes, the plan is to modify qdbuscpp2xml to add support for default service name,
default object name and default session (all optional, only part of the generated code
where it makes sense, like in this case), so this line would become:
org::kde::KIO::UIServer uiserver;

Anyway, this part (simplifying the constructor of dbus interfaces) is not specific to
uiserver at all, the same problem/solution applies to all of the kde code that uses DBUS interfaces.

The point is that there is really no reason to duplicate the uiserver API into Observer if
we can just use that API directly. If your observer methods do nothing else but
forward the exact same call to uiserver, then it's pointless. 
If there needs to be some added logic, then ok.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list