Preparing terrain for kio_uiserver

[Robert Knight]

Hi Rafael,

I have some comments on the method documentation:

setJobIcon:

> Set the icon that will be showed to @p jobIcon.

Should be:  "Set the icon associated with this job to @p jobIcon"

jobIcon:

>       * Returns the icon to be showed on the kio_uiserver when
>       * drawing this job
>       * If not set, this will return the default app icon
>       * that launched this job

Should be:  "Returns the icon associated with this job.  If no icon
has been set explicitly using setJobIcon, the icon associated with the
application that started this job will be returned."

appName:

> Returns the app friendly name that launched this job

I don't understand what "app friendly name means", could you explain?

internalAppName:

> Returns the app internal name that launched this job

I don't understand what "app internal name" means, could you explain?

Small language issue:  Please use the full word "application" instead of "app".


Regarding your reply:

> It may be extended on the future for having support for kind of movies,
> or so. It could be a really interesting improvement, but I prefer having
> the base mechanism working.

SVG animations would probably be useful, but not "movies" in the sense
of a sequence of raster images (eg. QMovie).  Still as you said, get
the basics working first.

On 22/12/06, Rafael Fernández López <ereslibre at gmail.com> wrote:
> Hi again,
>
> This mail is because I didn't tell ya why this patch is <relatively> needed.
> I'm working in an improvement of the kio_uiserver, and it is able to show
> some information about jobs (such as progress, the app that launched it, the
> icon of the app that launched it...). Is necessary to have some kind of
> getters (and setters) for the job to let the observer read that info and
> send it to the uiserver through dbus.
>
> I omitted having setters for the appName and the internalAppName attributes,
> since they shoudn't change during job life time. For example, the icon can
> be set to let (as example) the same app that launched different jobs for
> different purposes having different icons, instead of showing the same icon
> app, that wouldn't say so much graphically.
>
> It may be extended on the future for having support for kind of movies, or
> so. It could be a really interesting improvement, but I prefer having the
> base mechanism working.
>
> Right now, it works perfectly, but it has to be extended to not only show
> jobs and their information, but letting users sending actions to jobs
> (pause, stop, cancel...), and so on.
>
> Bye,
> Rafael Fernández López.
>