Preparing terrain for kio_uiserver

[Rafael Fernández López]

Hi,

2006/12/21, Kevin Ottens <ervin at kde.org>:
>
> Le Jeudi 21 Décembre 2006 12:36, David Faure a écrit :
> > You're not actually describing the change in your email. AFAICS you
> added a
> > jobIcon and a appName parameters to every job (the factory methods and
> the
> > constructors).
>
> Yep, more explanation would be welcome. Why did they get added in the
> first
> place?


More explanation will be given with the new patch.

> I object to the cluttering of all those methods with new arguments. Why
> not
> > just let the app code call job->ui()->setIcon() after getting a job from
> > e.g. KIO::copy()? Yes I think icon()/setIcon() belongs in JobUiDelegate
> > rather, if Kevin agrees.
>
> Yes, I fully agree with this. There's no point at trying to split
> gui/non-gui
> in jobs[1] if as soon as I come back to it I find new gui related methods
> in
> the jobs again. =)


The icon will live into the JobUiDelegate, it's ok.

Regards.


Bye,
Rafael Fernández López.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20061221/358371ae/attachment.htm>