Preparing terrain for kio_uiserver

[Kevin Ottens]

Le Jeudi 21 Décembre 2006 12:36, David Faure a écrit :
> You're not actually describing the change in your email. AFAICS you added a
> jobIcon and a appName parameters to every job (the factory methods and the
> constructors).

Yep, more explanation would be welcome. Why did they get added in the first 
place?

> I object to the cluttering of all those methods with new arguments. Why not
> just let the app code call job->ui()->setIcon() after getting a job from
> e.g. KIO::copy()? Yes I think icon()/setIcon() belongs in JobUiDelegate
> rather, if Kevin agrees.

Yes, I fully agree with this. There's no point at trying to split gui/non-gui 
in jobs[1] if as soon as I come back to it I find new gui related methods in 
the jobs again. =)

Regards.

[1] Note that it's only partly done in KIO::Job, but true for KJob.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20061221/0d6e0f35/attachment.sig>