[PATCH] Cosmetic patches for KDE 3.5.4

[Remi Villatel]

Aaron J. Seigo wrote:

>> *kdelibs/kdeui/kpopupmenu.cpp.diff*

>> To remove the unnecessary line drawn with highlight() color on top of
>> every popup menu title. (A debug feature that was never removed?)

> no, a line to make it look ok in certain styles. if styles that don't draw 
> properly distinguished header pixmaps are essentially not around anymore, 
	[---CUT---]

AFAIK all the styles draw a regular (Q)header as popup menu title, even 
the ancient ones like CDE or KDE classic. I think it's "safe" to remove 
the line. Besides, it seems more logical to me to patch the styles 
instead of KDE if we want just _certain_ styles to look OK.

>> *kdebase/kicker/kicker/ui/k_mnu.cpp.diff*

>> To re-enable the PopupMenuTitles which are disabled for an unknown
>> reason. (They are always enabled everywhere else. Why not here too?)

> here's the "unknown" reason: the titles have no meaning from an activation 
> POV. if they are enabled then when using the keyboard moving up and down the 
	[---CUT---]

I didn't think about that! It's unnatural to me to use the keyboard in 
the KMenu... well, in any menu. I tried, and you're right, that's strange.

> in other menus they are actually selectable and do something... the window 
> list menu used to (i don't think it actually does anymore, however) allow one 
> to click on those entries and go to the selected desktop.

No, they don't do anything (anymore), they don't react to the mouse nor 
to the keyboard. That's exactly how the menu headers should be in the 
KMenu and that's what I meant when I said there was no reason why they 
should be deactivated. I was talking from a visual PoV. So here comes 
the question: Does Kicker actually need special headers when the 
KPopupTitles already exist, have the same role and behave as expected?

To replace the PopupMenuTitles with (regular) KPopupTitles is the way to 
go, IMHO. I will try that.

>> *kdebase/kicker/kicker/ui/popupmenutitle.h.diff*
	[---CUT---]	

> see above remarks on same feature in kdelibs

The same to you.

And you don't say anything about my 4 other patches, does it mean 
they're not worth mentioning or that they are already applied? ;-)

See ya,

-- 
==================
Remi Villatel
maxilys_ at _tele2.fr
==================