[PATCH] Cosmetic patches for KDE 3.5.4

[Aaron J. Seigo]

On Sunday 06 August 2006 15:32, Remi Villatel wrote:
> Aaron J. Seigo wrote:
> >> *kdelibs/kdeui/kpopupmenu.cpp.diff*
> >>
> >> To remove the unnecessary line drawn with highlight() color on top of
> >> every popup menu title. (A debug feature that was never removed?)
> >
> > no, a line to make it look ok in certain styles. if styles that don't
> > draw properly distinguished header pixmaps are essentially not around
> > anymore,
>
> 	[---CUT---]
>
> AFAIK all the styles draw a regular (Q)header as popup menu title, even
> the ancient ones like CDE or KDE classic. I think it's "safe" to remove
> the line. Besides, it seems more logical to me to patch the styles
> instead of KDE if we want just _certain_ styles to look OK.

that's a wonderful theory that resulted in much frustration in the past. =)

in any case, you can probably commit this patch and just let them eat cake for 
using crappy styles in this day and age ...

> >> *kdebase/kicker/kicker/ui/k_mnu.cpp.diff*
> >>
> >> To re-enable the PopupMenuTitles which are disabled for an unknown
> >> reason. (They are always enabled everywhere else. Why not here too?)
> >
> > here's the "unknown" reason: the titles have no meaning from an
> > activation POV. if they are enabled then when using the keyboard moving
> > up and down the
>
> 	[---CUT---]
>
> I didn't think about that! It's unnatural to me to use the keyboard in
> the KMenu... well, in any menu. I tried, and you're right, that's strange.

keyboard access of the menu is one of the features we work to provide.

> > in other menus they are actually selectable and do something... the
> > window list menu used to (i don't think it actually does anymore,
> > however) allow one to click on those entries and go to the selected
> > desktop.
>
> No, they don't do anything (anymore), they don't react to the mouse nor
> to the keyboard. That's exactly how the menu headers should be in the
> KMenu and that's what I meant when I said there was no reason why they
> should be deactivated. I was talking from a visual PoV. So here comes
> the question: Does Kicker actually need special headers when the
> KPopupTitles already exist, have the same role and behave as expected?
>
> To replace the PopupMenuTitles with (regular) KPopupTitles is the way to
> go, IMHO. I will try that.

would be nice... IIRC the reason was some small thing to do with the paint 
methods... fonts and alignment? sth like that =) 

> And you don't say anything about my 4 other patches, does it mean
> they're not worth mentioning or that they are already applied? ;-)

it means that they are out of my purview. i'll let others comment on them 
first. if that fails i'll look at the rest of them again.

-- 
Aaron J. Seigo
Undulate Your Wantonness
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060806/e238b785/attachment.sig>