[PATCH] Cosmetic patches for KDE 3.5.4

[Aaron J. Seigo]

On Friday 04 August 2006 17:00, Remi Villatel wrote:
> *kdelibs/kdeui/kpopupmenu.cpp.diff*
>
> To remove the unnecessary line drawn with highlight() color on top of
> every popup menu title. (A debug feature that was never removed?)

no, a line to make it look ok in certain styles. if styles that don't draw 
properly distinguished header pixmaps are essentially not around anymore, 
then i'm fine with removing the line. but it was there because a lot of 
people used styles (e.g. keramik) that this looked like crap without the 
line.

> *kdebase/kicker/kicker/ui/k_mnu.cpp.diff*
>
> To re-enable the PopupMenuTitles which are disabled for an unknown
> reason. (They are always enabled everywhere else. Why not here too?)

here's the "unknown" reason: the titles have no meaning from an activation 
POV. if they are enabled then when using the keyboard moving up and down the 
menu would mean pressing up/down twice even though the entry can't actually 
be selected to do anything meaningful.

in other menus they are actually selectable and do something... the window 
list menu used to (i don't think it actually does anymore, however) allow one 
to click on those entries and go to the selected desktop.

this patch would actually be a de-polishing, as it was purposeful with an 
actual improvement in interaction.

> *kdebase/kicker/kicker/ui/popupmenutitle.h.diff*
>
> To remove the unnecessary line drawn with highlight() color on top of
> every popup menu title. (Another forgotten debug feature?)

see above remarks on same feature in kdelibs

-- 
Aaron J. Seigo
Undulate Your Wantonness
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060806/2bc4f58a/attachment.sig>