[PATCH] Cosmetic patches for KDE 3.5.4

[Remi Villatel]

Hi there,

Here are the cosmetic patches I've applied since KDE 3.5.2 but of which
I've always delayed the posting for an unknown reason. I hope it's OK to
flood --just a little-- the list.

*kdelibs/kdeui/karrowbutton.cpp.diff*

To prevent the shift of the arrow when the style doesn't want it.
(Hardcoded shifting is a real nuisance.)

Also to set Style_MouseOver when necessary so that Taskbar2's tiny
window list button looks better.

*kdelibs/kdeui/kpopupmenu.cpp.diff*

To remove the unnecessary line drawn with highlight() color on top of
every popup menu title. (A debug feature that was never removed?)

*kdelibs/kdeui/ktabbar.cpp.diff*

To make the tabs respect the reverse layout. (Pixmap on the right, label
on the left.) Note: Doesn't work with 'kcmshell panel' (yet).

*kdelibs/kdeui/ktabctl.cpp.diff*

To remove the (ugly) hardcoded drawing.

*kdelibs/kdeui/ktoolbarbutton.cpp.diff*

To remove the strange grey/blue color used by the label of hovered
toolbuttons (KGlobalSettings::toolBarHighlightColor() is a hardcoded
color) and the hardcoded buttonText() color too. (Most styles fill the
toolbar with background() which may makes buttonText() illegible.)

Also to make the toolbuttons respect the reverse layout. (Pixmap on the
right and label on the left for "Text Alongside Icons" and popup
indicator on the left when available.)

Plus a few simplifications in the drawing.

IMHO, a few "KPE_toolbutton_something" would be really nice to give more
control to the styles plugins.

---------------------

*kdebase/kicker/kicker/ui/k_mnu.cpp.diff*

To re-enable the PopupMenuTitles which are disabled for an unknown
reason. (They are always enabled everywhere else. Why not here too?)

*kdebase/kicker/kicker/ui/popupmenutitle.h.diff*

To remove the unnecessary line drawn with highlight() color on top of
every popup menu title. (Another forgotten debug feature?)

---------------------

I hope a few of them will be accepted so that I won't have to patch KDE
3.5.5 too.  ;-)

-- 
==================
Remi Villatel
maxilys_ at _tele2.fr
==================
-------------- next part --------------
A non-text attachment was scrubbed...
Name: k_mnu.cpp.diff
Type: text/x-patch
Size: 1372 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060805/631b56b0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: karrowbutton.cpp.diff
Type: text/x-patch
Size: 905 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060805/631b56b0/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kpopupmenu.cpp.diff
Type: text/x-patch
Size: 343 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060805/631b56b0/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ktabbar.cpp.diff
Type: text/x-patch
Size: 921 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060805/631b56b0/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ktabctl.cpp.diff
Type: text/x-patch
Size: 1239 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060805/631b56b0/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ktoolbarbutton.cpp.diff
Type: text/x-patch
Size: 5835 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060805/631b56b0/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: popupmenutitle.h.diff
Type: text/x-patch
Size: 354 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060805/631b56b0/attachment-0006.bin>