Suspicious code in kdebase 3.5.2

Lubos Lunak l.lunak at suse.cz
Sun Apr 9 19:09:38 BST 2006


On Sunday 09 April 2006 11:39, Thiago Macieira wrote:
> Lubos Lunak wrote:
> >> > !(*dot = 0) is  always true and therefore unneccessary. Or do you
> >> > mean !(*dot ==0)?
> >>
> >> Indeed, fixed.
> >
> > No, that's an obscurism coming from I don't even remember where.
> > Reverted.
>
> Could you instead change that to:
>   *dot = 0;
> And remove the if, since it always evaluates to true?

 I'm not sure which if you mean, nothing there is guaranteed to always 
evaluate to true. I've already rewritten the code to look better.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/




More information about the kde-core-devel mailing list