Suspicious code in kdebase 3.5.2

[Ismail Donmez]

Pazar 9 Nisan 2006 12:27 tarihinde, Lubos Lunak şunları yazmıştı: 
> On Saturday 08 April 2006 10:43, Ismail Donmez wrote:
> > Hi Christoph,
> > Cumartesi 8 Nisan 2006 11:21 tarihinde, Christoph Bartoschek şunları
> > yazmıştı: [...]
> >
> > > - kwin/utils.cpp:313
> > >
> > > !(*dot = 0) is  always true and therefore unneccessary. Or do you mean
> > > !(*dot ==0)?
> >
> > Indeed, fixed.
>
>  No, that's an obscurism coming from I don't even remember where. Reverted.

That was pretty obscure, thanks for unobfuscating it.

> > > - kcontrol/crypto/crypto.cpp:1980
> > >
> > > cr is allocated with operator new[] use delete []
> >
> > Fixed.
>
>  As far as I can tell you haven't committed a single of these changes to
> trunk, do you intend to do so? We have enough code in 3.5.x that's not in
> trunk already, no need to make it even worse :(.

Forwardported all my changes now.

Regards,
ismail
-- 
<Terwou> \\o \o> <o/ o//
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060409/2ac4883c/attachment.sig>