Suspicious code in kdebase 3.5.2

Thiago Macieira thiago at kde.org
Sun Apr 9 10:39:33 BST 2006


Lubos Lunak wrote:
>> > !(*dot = 0) is  always true and therefore unneccessary. Or do you
>> > mean !(*dot ==0)?
>>
>> Indeed, fixed.
>
> No, that's an obscurism coming from I don't even remember where.
> Reverted.

Could you instead change that to:
  *dot = 0;
And remove the if, since it always evaluates to true?

-- 
Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
  thiago.macieira (AT) trolltech.com     Trolltech AS
    GPG: 0x6EF45358                   |  Sandakerveien 116,
    E067 918B B660 DBD1 105C          |  NO-0402
    966C 33F5 F005 6EF4 5358          |  Oslo, Norway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060409/10177bc7/attachment.sig>


More information about the kde-core-devel mailing list